Increment libclamav SO version (11.0.0 instead of 9.2.0)#778
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Nov 23, 2022
Merged
Increment libclamav SO version (11.0.0 instead of 9.2.0)#778val-ms merged 1 commit intoCisco-Talos:mainfrom
val-ms merged 1 commit intoCisco-Talos:mainfrom
Conversation
The libclamav SO ABI has changed since 0.103 due to: - Removal of the CLAMAV_PUBLIC namespace by no longer using libclamav.map - Change of: extern const char *cl_strerror(int clerror); To: extern const char *cl_strerror(cl_error_t clerror); See: https://github.com/micahsnyder/clamav-micah/blob/e66c00f41c9b620a0f2ef67ae359c07049ace52f/libclamav/clamav.h#L1203 - Introduction of Rust symbols to namespace. Ref: Cisco-Talos#775 As such, it seems fair to increase the SO version. This is an amendment to this prior change for the ClamAV 1.0.0 version bump: Cisco-Talos@0dd6ab3 Instead of incrementing SO Current version to 11, and Age to 2, we'll increment SO Current version to 11, and reset Age to 0. So the SO version will effectively go from: 9.1.0 to: 11.0.0
This was referenced Nov 22, 2022
ragusaa
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libclamav SO ABI has changed since 0.103 due to:
Ref: #775
As such, it seems fair to increase the SO version. This is an amendment to this prior change for the ClamAV 1.0.0 version bump:
0dd6ab3
Instead of incrementing SO Current version to 11, and Age to 2, we'll increment SO Current version to 11, and reset Age to 0.
So the SO version will effectively go from:
9.1.0
to:
11.0.0