Remove Docker files from repository (0.105.2)#765
Merged
val-ms merged 2 commits intoCisco-Talos:dev/0.105.2from Feb 1, 2023
Merged
Remove Docker files from repository (0.105.2)#765val-ms merged 2 commits intoCisco-Talos:dev/0.105.2from
val-ms merged 2 commits intoCisco-Talos:dev/0.105.2from
Conversation
Contributor
|
Attempting to build the container from the instructions did not work for me. I got this error |
Contributor
Author
|
That error looks familiar to me as well, though I don't remember when I saw it or why. |
Contributor
Author
|
Note: the main PR is #764. This current one is a copy for the 0.105 release. |
ragusaa
suggested changes
Nov 21, 2022
README.Docker.md
Outdated
| to build the image locally instead. | ||
|
|
||
| To do this, you will need to get the `Dockerfile` and the supporting `scripts/` | ||
| directory from the [clamav-docker Git repository](https://github.com/Cisco-Talos/clamav-docker/tree/main/clamav). |
Contributor
There was a problem hiding this comment.
May be better to have this be a link to the actual repo, so that the user can copy/paste to check out the repo. I.e. https://github.com/Cisco-Talos/clamav-docker
ragusaa
approved these changes
Nov 22, 2022
The supported Docker files used to build the official clamav images are now located here: https://github.com/Cisco-Talos/clamav-docker Also fix some minor errors in the INSTALL.md file.
f63dd7c to
d7909a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supported Docker files used to build the official clamav images are now located here: https://github.com/Cisco-Talos/clamav-docker
Also fix some minor errors in the INSTALL.md file.
Cherry-pick of #764