Skip to content

Remove Docker files from repository (0.105.2)#765

Merged
val-ms merged 2 commits intoCisco-Talos:dev/0.105.2from
val-ms:CLAM-2188-remove-docker-files-0.105.2
Feb 1, 2023
Merged

Remove Docker files from repository (0.105.2)#765
val-ms merged 2 commits intoCisco-Talos:dev/0.105.2from
val-ms:CLAM-2188-remove-docker-files-0.105.2

Conversation

@val-ms
Copy link
Contributor

@val-ms val-ms commented Nov 18, 2022

The supported Docker files used to build the official clamav images are now located here: https://github.com/Cisco-Talos/clamav-docker

Also fix some minor errors in the INSTALL.md file.

Cherry-pick of #764

@ragusaa
Copy link
Contributor

ragusaa commented Nov 21, 2022

Attempting to build the container from the instructions did not work for me. I got this error

/bin/sh: 1: curl: not found
-- The C compiler identification is GNU 10.2.1
-- The CXX compiler identification is GNU 10.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: /usr/bin/git (found version "2.30.2") 
-- Rust tool `cargo` not found.
-- Rust tool `rustc` not found.
-- Rust tool `rustup` not found.
-- Rust tool `rust-gdb` not found.
-- Rust tool `rust-lldb` not found.
-- Rust tool `rustdoc` not found.
-- Rust tool `rustfmt` not found.
-- Rust tool `bindgen` not found.
CMake Error at cmake/FindRust.cmake:289 (string):
  string sub-command STRIP requires two arguments.
Call Stack (most recent call first):
  CMakeLists.txt:124 (find_package)


CMake Error at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find Rust (missing: cargo_EXECUTABLE)
Call Stack (most recent call first):
  /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindRust.cmake:315 (find_package_handle_standard_args)
  CMakeLists.txt:124 (find_package)


@val-ms
Copy link
Contributor Author

val-ms commented Nov 21, 2022

That error looks familiar to me as well, though I don't remember when I saw it or why.

@val-ms
Copy link
Contributor Author

val-ms commented Nov 21, 2022

Note: the main PR is #764. This current one is a copy for the 0.105 release.

README.Docker.md Outdated
to build the image locally instead.

To do this, you will need to get the `Dockerfile` and the supporting `scripts/`
directory from the [clamav-docker Git repository](https://github.com/Cisco-Talos/clamav-docker/tree/main/clamav).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be better to have this be a link to the actual repo, so that the user can copy/paste to check out the repo. I.e. https://github.com/Cisco-Talos/clamav-docker

The supported Docker files used to build the official clamav images are
now located here: https://github.com/Cisco-Talos/clamav-docker

Also fix some minor errors in the INSTALL.md file.
@val-ms val-ms force-pushed the CLAM-2188-remove-docker-files-0.105.2 branch from f63dd7c to d7909a4 Compare February 1, 2023 19:08
@val-ms val-ms merged commit 7144658 into Cisco-Talos:dev/0.105.2 Feb 1, 2023
@val-ms val-ms deleted the CLAM-2188-remove-docker-files-0.105.2 branch February 1, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants