Clam 2168 CMake: remove option to build using external TomsFastMath library#742
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Nov 10, 2022
Merged
Conversation
ClamAV requires non-default build options for TomsFastMath to support bigger floating point numbers. Without this change, database and Windows EXE/DLL authenticode certificate validation may fail. The option to build with an external TomsFastMath library should be removed. The `ENABLE_EXTERNAL_TOMSFASTMATH` build should be ignored, with some sort of warning. This commit removes the option. If used, the build will not fail, but CMake will print a warning that the unused option was ignored.
val-ms
force-pushed
the
CLAM-2168-remove-external-tfm-option
branch
from
8e74d18 to
34303c2
Compare
Contributor
Author
|
Updated per review comments offline to add missing PR link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClamAV requires non-default build options for TomsFastMath to support bigger floating point numbers. Without this change, database and Windows EXE/DLL authenticode certificate validation may fail.
See also discussion in #736
The option to build with an external TomsFastMath library should be removed. The
ENABLE_EXTERNAL_TOMSFASTMATHbuild should be ignored, with some sort of warning.This commit removes the option. If used, the build will not fail, but CMake will print a warning that the unused option was ignored.
Fixes: #743