Clam 1675 container cache fix#724
Merged
val-ms merged 2 commits intoCisco-Talos:mainfrom Oct 21, 2022
Merged
Conversation
Signatures that have conditions on a Container type or Intermediates types may not match if the target file is scanned outside of the container first, and cached as clean. The solution to this is to disable caching for layers that would have matched except for the Container (or Intermediates) condition.
ragusaa
approved these changes
Oct 21, 2022
val-ms
force-pushed
the
CLAM-1675-container-cache-fix
branch
from
ffa7dc4 to
498e365
Compare
ragusaa
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix caching bug with Intermediates & Container conditions
Signatures that have conditions on a Container type or Intermediates types may not match if the target file is scanned outside of the container first, and cached as clean.
The solution to this is to disable caching for layers that would have matched except for the Container (or Intermediates) condition.
Add regression test for Container/Intermediates cache issue