Speed up freeing of signatures on shutdown#712
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Oct 7, 2022
Merged
Conversation
ragusaa
force-pushed
the
CLAM-1995-SpeedupFree
branch
6 times, most recently
from
a878dcb to
5aad18d
Compare
Speed up freeing of signatures by tracking all malloced blocks instead of having to find duplicates in our data structures on signature unload.
ragusaa
force-pushed
the
CLAM-1995-SpeedupFree
branch
from
1baa2ab to
4d5e27d
Compare
val-ms
approved these changes
Oct 7, 2022
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Code looks great. Local performance testing looks great. QA pipelines look great.
Excellent!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.