Fix scan error when image fuzzy hash fails (0.105.1)#644
Merged
val-ms merged 1 commit intoCisco-Talos:dev/0.105.1from Jul 19, 2022
Merged
Fix scan error when image fuzzy hash fails (0.105.1)#644val-ms merged 1 commit intoCisco-Talos:dev/0.105.1from
val-ms merged 1 commit intoCisco-Talos:dev/0.105.1from
Conversation
Scanning a file containing an image where it fails to calculate the image fuzzy hash may cause the entire scan to end with an error. This commit fixes that by ignoring any image fuzzy hash failure. If calculating the hash fails, the hash is left uninitialized (all zeroes). To prevent doing image fuzzy hash lookups when it failed, I added a boolean that is set to true only after creating the hash. Fixes: Cisco-Talos#600 Fixes: Cisco-Talos#593
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #618
Scanning a file containing an image where it fails to calculate the
image fuzzy hash may cause the entire scan to end with an error.
This commit fixes that by ignoring any image fuzzy hash failure.
If calculating the hash fails, the hash is left uninitialized (all
zeroes). To prevent doing image fuzzy hash lookups when it failed,
I added a boolean that is set to true only after creating the hash.
Fixes: #600
Fixes: #593