Skip to content

Add PDF object extraction recursion limits#629

Merged
val-ms merged 2 commits intoCisco-Talos:mainfrom
val-ms:CLAM-1967-PDF-object-recursion
Oct 21, 2022
Merged

Add PDF object extraction recursion limits#629
val-ms merged 2 commits intoCisco-Talos:mainfrom
val-ms:CLAM-1967-PDF-object-recursion

Conversation

@val-ms
Copy link
Contributor

@val-ms val-ms commented Jul 8, 2022

Adds in object extraction recursion limits for object extraction as well
as well parsing string, array, and dictionaries during extraction.
The limit is set to 25.

@val-ms val-ms added the 🍒cherry-pick-candidate A PR that should be backported once approved. label Jul 18, 2022
Adds in object extraction recursion limits for object extraction as well
as well parsing string, array, and dictionaries during extraction.
The limit is set to 25.

Places recursion-depth variable in pdf parse context structure.
@val-ms val-ms force-pushed the CLAM-1967-PDF-object-recursion branch from a9ab110 to f12f943 Compare October 20, 2022 23:38
@val-ms
Copy link
Contributor Author

val-ms commented Oct 20, 2022

I squashed the fixup commits, rebased and resolved one minor merge conflict, and then added a commit to update the generated sys.rs file that was neglected in PR review from an unrelated PR. I figure this one will merge very shortly (soon as I see it pass testing)... and I want to get that sys.rs update in.

@val-ms val-ms merged commit c052dbe into Cisco-Talos:main Oct 21, 2022
@val-ms val-ms deleted the CLAM-1967-PDF-object-recursion branch May 7, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒cherry-pick-candidate A PR that should be backported once approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants