Skip to content

Clam 1648 Fix benign heap over-read when loading some LDB signatures using byte-compare feature #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
val-ms merged 1 commit into from
May 28, 2022
Merged

Clam 1648 Fix benign heap over-read when loading some LDB signatures using byte-compare feature #583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions libclamav/matcher-byte-comp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,15 +988,14 @@ unsigned char *cli_bcomp_normalize_buffer(const unsigned char *buffer, uint32_t
void cli_bcomp_freemeta(struct cli_matcher *root, struct cli_bcomp_meta *bm)
{

int i = 0;
uint32_t i = 0;

if (!root || !bm) {
return;
}

/* can never have more than 2 */
if (bm->comps) {
for (i = 0; i < 2; i++) {
for (i = 0; i < bm->comp_count; i++) {
if (bm->comps[i]) {
MPOOL_FREE(root->mempool, bm->comps[i]);
bm->comps[i] = NULL;
Expand Down