Zip parser: tolerate 2-byte overlap in file entries#561
Merged
val-ms merged 2 commits intoCisco-Talos:mainfrom Jul 18, 2022
Merged
Zip parser: tolerate 2-byte overlap in file entries#561val-ms merged 2 commits intoCisco-Talos:mainfrom
val-ms merged 2 commits intoCisco-Talos:mainfrom
Conversation
The heuristic to alert on overlapping file entries is detecting some non-malicious JAR files observed in critical enterprise software. The goal with overlap detection is to alert on non-recursive zip- bombs, so this tiny overlap isn't a concern. We'll allow a 2-byte overlap so we don't alert on such zips.
m-sola
reviewed
May 25, 2022
Contributor
m-sola
left a comment
m-sola
left a comment
There was a problem hiding this comment.
Functionally, confirmed no more alert on provided test file.
I don't love how all of this is on one line. If it's not too much trouble could we break the logic up into something more readable?
Contributor
Author
Ok I think I fixed it in a nice way. Please re-review. |
val-ms
added
the
🍒cherry-pick-candidate
This was referenced Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heuristic to alert on overlapping file entries is detecting some
non-malicious JAR files observed in critical enterprise software.
The goal with overlap detection is to alert on non-recursive zip-
bombs, so this tiny overlap isn't a concern.
We'll allow a 2-byte overlap so we don't alert on such zips.
Ref: CLAM-1763