Windows: code quality improvement for --move and --remove options#1470
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Mar 22, 2025
Merged
Conversation
When the --move or --remove options are used, ClamAV carefully traverses the file path one layer at a time so as to avoid following a directory that is a symlink or reparse point. We do this for directories, but could also do it for files. Only an admin should be able to create a reparse point for a file, but it is better to be consistent. Thank you to Maxim Suhanov for reporting this issue.
TheRaynMan
approved these changes
Mar 19, 2025
Contributor
TheRaynMan
left a comment
TheRaynMan
left a comment
There was a problem hiding this comment.
Known option change, looks good to me.
Contributor
Author
|
Waiting on internal test pipelines. Seems like a firewall issue or something to our win 11 arm64 test node. The move/remove/copy action tests worked fine though for win 10 x64, win 10 x86, and win 8 x64. |
Contributor
Author
|
Test pipelines looking okay now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the --move or --remove options are used, ClamAV carefully traverses the file path one layer at a time so as to avoid following a directory that is a symlink or reparse point.
We do this for directories, but could also do it for files. Only an admin should be able to create a reparse point for a file, but it is better to be consistent.
Thank you to Maxim Suhanov for reporting this issue.