clamd: Fix bug reporting memory stats, used by clamdtop#1465
Merged
Conversation
val-ms
requested changes
Mar 13, 2025
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Manual testing looks great. Fixes memstats reporting with the zSTATS command as well as in clamdtop. The commit message needs a little something. Will DM.
jhumlick
force-pushed
the
CLAM-2742-memstats
branch
from
f08e3ab to
d28ec46
Compare
Contributor
Author
|
I have updated the commit message. |
val-ms
changed the title
jhumlick
force-pushed
the
CLAM-2742-memstats
branch
3 times, most recently
from
0152af3 to
1cbea3c
Compare
ClamD's STATS API reports process memory stats on systems that provide the `mallinfo()` system call. This feature is used by ClamDTOP to show process memory usage. When we switched to the CMake build system, we neglected to add the check for the `mallinfo()` system call and so broke ClamD memory usage reporting. This commit adds the CMake check for `mallinfo()` and sets HAVE_MALLINFO, if found. Fixes: #706 Jira: CLAM-2742
jhumlick
force-pushed
the
CLAM-2742-memstats
branch
from
1cbea3c to
18120a0
Compare
val-ms
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClamD's STATS API reports process memory stats on systems that
provide the
mallinfo()system call.This feature is used by ClamDTOP to show process memory usage.
When we switched to the CMake build system, we neglected to add the
check for the
mallinfo()system call and so broke ClamD memoryusage reporting.
This commit adds the CMake check for
mallinfo()and setsHAVE_MALLINFO, if found.
Fixes: #706
Jira: CLAM-2742