Merged
Conversation
val-ms
approved these changes
Feb 3, 2025
Contributor
val-ms
left a comment
There was a problem hiding this comment.
Thanks for the fix! As we confirmed in direct message conversation, this issue only affects running in debug mode (i.e. clamscan's --debug or clamd's Debug yes options).
With the latest update, your fix looks good to me. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, while running clamav in debug mode, we found a file that was hanging the process.
After investigation, it turns out it is an eml with a winmail.data attachment > 8kb
So, in order to dump, it loops over the file with BUFSIZ chunks using fmap_readn
fmap_readn can return either -1 or 0 (
clamav/libclamav/fmap.h
Line 301 in 86a3835
It is hard to add a test, we can't share the original file and I found no way to create a similar file