Clam 2638 0.103.12 and backports#1346
Merged
val-ms merged 10 commits intoCisco-Talos:dev/0.103.12from Aug 30, 2024
Merged
Conversation
fmap_need_off_once() may return an unaligned pointer. This in return leads to an unaligned access during the load of the uint32_t variables loading to failures on architectures not supporting unaligned access. This was reported to the Debian BTS as #1073128. [bigeasy: Commit message, reworked the patch a bit]. Link: https://bugs.debian.org/1073128 Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
val-ms
force-pushed
the
CLAM-2638-0.103.12-and-backports
branch
13 times, most recently
from
2a6f20f to
17d1976
Compare
The build pipeline used to build clamav packages and then test those packages with a rudimentary test set. This change will build the clamav packages in one pipeline - then test the packages in a new test pipeline. The new test pipeline will use the larger test suite that we use for testing from-source builds in the "regular" test pipeline.
If using DatabaseCustomURL to download a CVD that Freshclam doesn't know about, i.e. one that is not in the hardcoded standard or optional database lists in freshclam.c, Freshclam will prune the database and then re-download it. This change makes it so we look for URL's with ".cvd" at the end and then take those into consideration when checking which CVD's (or CLD's) should be pruned. Note that I didn't change the interface to fc_prune_database_directory(). That would have been cleaner, but would've changed the public API and I want to backport this fix.
Due to build issues with libldtl and/or Autotools in Ubuntu:22.04, perform the build within a Docker container running Ubuntu:18.04.
We run a set of from-source builds that use the tarball. Distcheck is being problematic, but if all the from-source builds work correctly, that may suffice to check the dist.
Encountered this error after updates to Visual Studio. 5>rarpch.cpp 5>c:\program files (x86)\windows kits\10\include\10.0.22621.0\um\winnt.h(2535): error C2338: Windows headers require the default packing option. Changing this can lead to memory corruption. This diagnostic can be disabled by building with WINDOWS_IGNORE_PACKING_MISMATCH defined. It seems that libclamunrar VS project file was set to 4-byte struct member alignment. Changing this to "Default" fixes the issue.
val-ms
force-pushed
the
CLAM-2638-0.103.12-and-backports
branch
2 times, most recently
from
ddc9200 to
515f183
Compare
rsundriyal
approved these changes
Aug 30, 2024
Contributor
rsundriyal
left a comment
rsundriyal
left a comment
There was a problem hiding this comment.
Looks good.
Although we can remove appcheck.
Contributor
Author
|
Makes sense. I'll remove appcheck and write up the news/changelog in the next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an unaligned pointer dereference issue on select architectures.
Fix courtesy of Sebastian Andrzej Siewior.
Fixes to Jenkins CI pipeline.
Fixed a bug causing CVDs downloaded by the
DatabaseCustomURLFreshclamconfig option to be pruned and then re-downloaded with every update.
Added the new 'valhalla' database name to the list of optional databases in
preparation for future work.
Before updating NEWS.md (change log) for 0.103.12, I also want to merge #1198