Clam 2585 ole check encrypted 3#1295
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Sep 11, 2024
Merged
Conversation
ragusaa
force-pushed
the
CLAM-2585-OleCheckEncrypted_3
branch
from
95feff1 to
903eb07
Compare
Contributor
|
Replaced by #1279 |
Contributor
|
My mistake, this one replaces the other. |
val-ms
requested changes
Jul 17, 2024
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Other the formatting, I don't have any other concerns.
ragusaa
force-pushed
the
CLAM-2585-OleCheckEncrypted_3
branch
2 times, most recently
from
74aa9b5 to
2057326
Compare
Contributor
Author
|
I ran clam-format to clean up the formatting, so I think this one is good to go. |
val-ms
force-pushed
the
CLAM-2585-OleCheckEncrypted_3
branch
from
2057326 to
481a8b6
Compare
Contributor
|
Just rebased with upstream main to get the CI fixes and other clang-format fixes. |
val-ms
approved these changes
Jul 22, 2024
Add keys to the metadata.json file that informs the user that a scanned ole2 file is encrypted. Information about the type of encryption is provided when the information is available. This feature co-authored by Micah Snyder.
val-ms
force-pushed
the
CLAM-2585-OleCheckEncrypted_3
branch
from
481a8b6 to
6d50a60
Compare
Contributor
|
Rebased again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OLE2 office documents, determine if it is encrypted.
Store this in JSON metadata/properties.
Also check the "alert-encrypted" option and alert if necessary.