Merged
Conversation
val-ms
force-pushed
the
CLAM-2427-CoverityIssues
branch
from
16895cf to
c7a606e
Compare
val-ms
approved these changes
Apr 13, 2024
val-ms
added
the
🍒cherry-pick-candidate
Immediately store pointers as new pointer type rather than using intermediate uint8_t pointer. Also "unneed" some of the "needed" pointers as soon as we're able to release them rather than holding on until the end of the UDF image. Add assorted debug messages and code comments. Make FileSetDescriptor optional as minor step towards supporting ExtendedFileEntries. Minor variable name changes for readability. Use tag_identifier enum for variable type rather than uint16_t and add "INVALID_DESCRIPTOR" (0) to enum and use it in the switch. This way we're not comparing enums with ints. Move GenericVolumeStructureDescriptor to udf.h.
val-ms
force-pushed
the
CLAM-2427-CoverityIssues
branch
from
c7a606e to
00c8158
Compare
This was referenced Apr 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed various issues reported by coverity. Issue numbers in the commit messages.