Merged
Conversation
Contributor
|
The changes look fine, and the unit tests pass. It would still be good to do a regression run after this is merged, since there are so many changes. |
ragusaa
approved these changes
Mar 28, 2024
As of ClamAV 0.105, PCRE2 is required. PCRE (1) is not an option, and there is also no option to disable PCRE support. This commit removes the dead code associated with those old build options.
As of ClamAV 0.105, libxml2 is required. There is also no option to disable PCRE support. This commit removes the dead code associated with the old build option.
As of ClamAV 0.105, libbz2 is required. There is also no option to disable bz2 support. This commit removes the dead code associated with the old build option.
As of ClamAV 0.105, libz is required. There is also no option to disable zlib support. This commit removes the dead code associated with the old build option.
As of ClamAV 0.105, libjson-c is required. There is also no option to disable libjson-c support. This commit removes the dead code associated with the old build option.
val-ms
force-pushed
the
CLAM-2427-coverity-issues-dead-code
branch
from
2e8a28a to
4c7e8c1
Compare
Contributor
Author
Yeah we'll definitely at least regression test the release candidate vs the 1.3.1 release. And it couldn't hurt to regression test sooner. |
Contributor
Author
|
I just rebased and force-pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a bunch of preprocessor checks around dead code for build configurations that are no longer supported (e.g. no bzip2, no pcre2, using pcre instead of pcre2, no libxml2, no json-c).
This "resolves" some coverity issues found in said dead code, and should make the code easier to understand and maintain.