Skip to content

Fix clamonacc infinite loop when a file has been deleted before scan#1150

Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom
gsuehiro:fix_clamonacc_infinite_loop
Jan 23, 2024
Merged

Fix clamonacc infinite loop when a file has been deleted before scan#1150
val-ms merged 1 commit intoCisco-Talos:mainfrom
gsuehiro:fix_clamonacc_infinite_loop

Conversation

@gsuehiro
Copy link
Contributor

The err variable is used as an escape condition for the while loop. This is a pointer.
Shouldn't *err be used?

Copy link
Contributor

@val-ms val-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce the issue and I wasn't able to trigger the infinite loop.
But your fix makes sense to me. Very nice catch. Thanks @gsuehiro.

@val-ms val-ms merged commit ac51005 into Cisco-Talos:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants