Skip to content

Add static-libs installation#1100

Merged
val-ms merged 2 commits intoCisco-Talos:mainfrom
driverxdw:install-static-libs
Nov 30, 2023
Merged

Add static-libs installation#1100
val-ms merged 2 commits intoCisco-Talos:mainfrom
driverxdw:install-static-libs

Conversation

@driverxdw
Copy link
Contributor

add static library installation in CMakeLists.txt of libclamav submodules

Copy link
Contributor

@val-ms val-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change makes sense to me and I can see this being useful if you want to statically link libclamav (and submodules) with some other program.

I'm running it through the test pipelines now.

@val-ms
Copy link
Contributor

val-ms commented Nov 27, 2023

Manual testing on Linux looks good:

❯ ls -la install/lib/
total 42252
drwxr-xr-x 3 micah micah     4096 Nov 27 10:36 ./
drwxr-xr-x 8 micah micah     4096 Nov 27 10:36 ../
-rw-r--r-- 1 micah micah 38642020 Nov 27 10:36 libclamav_rust.a
-rw-r--r-- 1 micah micah  3696484 Nov 27 10:36 libclamav_static.a
-rw-r--r-- 1 micah micah   145808 Nov 27 10:35 libclammspack_static.a
-rw-r--r-- 1 micah micah    16110 Nov 27 10:35 libclamunrar_iface_static.a
-rw-r--r-- 1 micah micah   633086 Nov 27 10:35 libclamunrar_static.a
-rw-r--r-- 1 micah micah   108684 Nov 27 10:36 libfreshclam_static.a
drwxr-xr-x 2 micah micah     4096 Nov 27 10:36 pkgconfig/

Copy link
Contributor

@val-ms val-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that the windows static build fails without these suggested changes.

Copy link
Contributor Author

@driverxdw driverxdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed it, thank you for your suggestion!

@driverxdw driverxdw requested a review from val-ms November 28, 2023 11:44
Copy link
Contributor

@val-ms val-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@val-ms val-ms merged commit 63fa9b4 into Cisco-Talos:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants