Add static-libs installation#1100
Merged
val-ms merged 2 commits intoCisco-Talos:mainfrom Nov 30, 2023
Merged
Conversation
val-ms
reviewed
Nov 27, 2023
Contributor
val-ms
left a comment
There was a problem hiding this comment.
The code change makes sense to me and I can see this being useful if you want to statically link libclamav (and submodules) with some other program.
I'm running it through the test pipelines now.
Contributor
|
Manual testing on Linux looks good: |
val-ms
requested changes
Nov 27, 2023
Contributor
val-ms
left a comment
There was a problem hiding this comment.
I found that the windows static build fails without these suggested changes.
Co-authored-by: Micah Snyder <[email protected]>
driverxdw
commented
Nov 28, 2023
Contributor
Author
driverxdw
left a comment
There was a problem hiding this comment.
I've fixed it, thank you for your suggestion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add static library installation in CMakeLists.txt of libclamav submodules