Clam 2484: Fix warning when scanning some HTML files#1084
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Nov 21, 2023
Merged
Clam 2484: Fix warning when scanning some HTML files#1084val-ms merged 1 commit intoCisco-Talos:mainfrom
val-ms merged 1 commit intoCisco-Talos:mainfrom
Conversation
HTML files with <style> blocks containing non-utf8 sequences are causing warnings when processing them to extract base64 encoded images. To resolve this, we can use the to_string_lossy() method that may allocate and sanitize a copy of the content if the non-utf8 characters are encountered. Resolves: Cisco-Talos#1082
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML files with <style> blocks containing non-utf8 sequences are causing warnings when processing them to extract base64 encoded images.
To resolve this, we can use the to_string_lossy() method that may allocate and sanitize a copy of the content if the non-utf8 characters are encountered.
Resolves: #1082