Fix PDF decryption issue for some empty password files#1079
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Nov 21, 2023
Merged
Fix PDF decryption issue for some empty password files#1079val-ms merged 1 commit intoCisco-Talos:mainfrom
val-ms merged 1 commit intoCisco-Talos:mainfrom
Conversation
Some PDF's with an empty password can't be decrypted. Investigation found that the problem is a strlen check to prevent an overflow rather than passing down the actual length of the allocated field. Specifically, the UE buffer may have NULL values in it, so a strlen check will claim the field is shorter than it is and then later checks fail because the length is the wrong size. While at it, I improved code comments on the function reading dictionary key-value strings and switched a flag use a bool rather than an int.
Contributor
|
Code looks fine. Verified more files were extracted with the PR and with MAIN. |
ragusaa
approved these changes
Nov 8, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some PDF's with an empty password can't be decrypted. Investigation found that the problem is a strlen check to prevent an overflow rather than passing down the actual length of the allocated field.
Specifically, the UE buffer may have NULL values in it, so a strlen check will claim the field is shorter than it is and then later checks fail because the length is the wrong size.
While at it, I improved code comments on the function reading dictionary key-value strings and switched a flag use a bool rather than an int.