Adds logging and changes return status for bad temp dir: Issue #1028#1037
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Oct 16, 2023
Merged
Adds logging and changes return status for bad temp dir: Issue #1028#1037val-ms merged 1 commit intoCisco-Talos:mainfrom
val-ms merged 1 commit intoCisco-Talos:mainfrom
Conversation
Kiggins26
force-pushed
the
InvalidTempDirFix
branch
from
39c51b5 to
a2f5594
Compare
val-ms
requested changes
Sep 28, 2023
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
A little more detail explaining why we care of the directory is invalid/doesn't exist would be good. Otherwise this seems like the right fix to me.
Kiggins26
force-pushed
the
InvalidTempDirFix
branch
2 times, most recently
from
afe9479 to
0c464fb
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
val-ms
reviewed
Oct 2, 2023
val-ms
requested changes
Oct 2, 2023
Kiggins26
force-pushed
the
InvalidTempDirFix
branch
from
0c464fb to
71ff816
Compare
val-ms
approved these changes
Oct 16, 2023
Contributor
val-ms
left a comment
val-ms
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the help @Kiggins26!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1028