Clam 2436 no clap no atty 1.0.4#1035
Merged
val-ms merged 2 commits intoCisco-Talos:dev/1.0.4from Oct 23, 2023
Merged
Conversation
atty is unmaintained but is still used by clap. Disabling the default features for cbindgen removes the clap dependency and thus removes atty. Resolves: https://github.com/Cisco-Talos/clamav/security/dependabot/2
The build is running a different link.exe than the MSVC linker, possibly the one provided by bash. Fix by deleting /usr/bin/link.exe See: https://yncat.github.io/2022/02/18/github-actions%E3%81%A7-msvc-%E3%81%AE-link-%E3%81%8C%E4%BD%BF%E3%81%88%E3%81%AA%E3%81%8F%E3%81%AA%E3%82%8B%E8%A9%B1.html
val-ms
force-pushed
the
CLAM-2436-no-clap-no-atty-1.0.4
branch
from
bc297fa to
590b2c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1021 for 1.0.4
After some fussing, I was able to figure out how to update with this command to prevent updating so far as to require a newer version of cargo/rust.
cargo update -p tempfile --precise 3.4.0So the MSRV will remain at 1.61 for 1.0.4, for now.