Merged
Conversation
val-ms
force-pushed
the
CLAM-2428-unrar-6.2.10
branch
from
bf3518f to
09f36d0
Compare
shutton
approved these changes
Aug 23, 2023
Contributor
shutton
left a comment
shutton
left a comment
There was a problem hiding this comment.
Thank goodness for "hide whitespace"
Seems fine. Probably no need to keep the old code around. If you do, I'd add a comment about what it used to do, and why you took it out.
val-ms
force-pushed
the
CLAM-2428-unrar-6.2.10
branch
from
09f36d0 to
b5c714f
Compare
I'm seeing 'error: unknown type name 'constexpr' with the UnRAR update. It seems that C++11 must be enabled for 'constexpr' keyword to be recognized.
val-ms
force-pushed
the
CLAM-2428-unrar-6.2.10
branch
from
b5c714f to
ac97afd
Compare
Contributor
Author
|
I'm still trying to figure out why GitHub's Mac pipeline is failing to use C++11 (and failing the the build). |
Because it includes rar.hpp, the UnRAR iface also uses C++11 features.
UnRAR logic replaces directory symlinks found within archive file entry file paths with actual directories by deleting them after they're extracted. Unfortunately, this logic extends to deleting existing directories if you set the `DestName` instead of the `DestPath` in this API: rc = RARProcessFile(hArchive, RAR_EXTRACT, NULL, destFilePath); In the future UnRAR may change to disable the `LinksToDirs()` feature if using the `DestName` parameter. In the meantime, this commit completely disables it for our use case.
This is a cherry-pick of commit 24f225c Modification to unrar codebase allowing skipping of files within Solid archives when parsing in extraction mode, enabling us to skip encrypted files while still scanning metadata and potentially scanning unencrypted files later in the archive.
Prevent allocating more than 1GB regardless of what is requested. RAR dictionary sizes may not be larger than 1GB, at least in the current version. This is a cherry-pick of commit 9b444e7
val-ms
force-pushed
the
CLAM-2428-unrar-6.2.10
branch
from
ac97afd to
8b0d290
Compare
Contributor
Author
|
Silly me. It was Now just to watch the test pipelines... |
Contributor
Author
|
Testing looking good after that last fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.