Windows: json-c 0.17 compatibility with ssize_t type definition#1002
Merged
val-ms merged 1 commit intoCisco-Talos:mainfrom Aug 25, 2023
Merged
Conversation
val-ms
force-pushed
the
CLAM-2422-json-c-0.17-compatibility
branch
3 times, most recently
from
c02404f to
28f71b9
Compare
json-c 0.17 defines the ssize_t type using a typedef on Windows. We have been setting ssize_t for Windows to a different type using a #define instead of a typedef. We should have been using a typedef since it is a type. However, we must also match the exact type they're setting it to or else the compiler will baulk because the types are different. Note: in C11, it's fine to use typedef the same type more than once, so long as you're defining it the same every time.
val-ms
force-pushed
the
CLAM-2422-json-c-0.17-compatibility
branch
from
28f71b9 to
10903af
Compare
Contributor
Author
|
Verbally approved by a teammate that trusts me too much. Also, I'm happy with the test results. |
7 tasks
val-ms
added
the
🍒cherry-pick-candidate
Contributor
Author
|
Probably should have backported this for 1.1 and 1.0. I'll throw together the PR's real quick. Hopefully no conflict. I'm unsure if the same issue exists with 0.103 with the Visual Studio build. It ... probably does. I'll investigate. |
This was referenced Oct 19, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json-c 0.17 defines the ssize_t type using a typedef on Windows. We have been setting ssize_t for Windows to a different type using a #define instead of a typedef.
We should have been using a typedef since it is a type. However, we must also match the exact type they're setting it to or else the compiler will baulk because the types are different.
Note: in C11, it's fine to use typedef the same type more than once, so long as you're defining it the same every time.