feat: Support expression-based filters in VS code extension #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnallman
approved these changes
Oct 22, 2025
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://circleci.atlassian.net/browse/PIPE-5237
Important note : Release-please will only create a release PR for releases with a
featorfixcommit message. If your PR starts withchore, your changes will NOT be released.Description
Adding validation support for expression-based filters: https://circleci.com/docs/reference/configuration-reference/#jobfilters
Implementation details
Added a oneof under filter, can either be string or the previous branches object.
How to validate
I followed the steps in HACKING.md to test locally, verified that the previous branches/tags were still valid and additionally strings are. Also validated the error & info messages were helpful.