Skip to content

Update folder installation in chrome for testing #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

Update folder installation in chrome for testing #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08efbff
Update the usage of install_dir parameter for chrome for testing
marboledacci Aug 19, 2025
c81e3ab
Remove zip
marboledacci Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commands/install_chrome_for_testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ parameters:
type: string
default: /usr/local/bin
description: >
Directory in which to download Chrome and the driver.
Directory in which to download and install Chrome and the driver.

install_chromedriver:
type: boolean
Expand Down
6 changes: 4 additions & 2 deletions src/scripts/install_chrome_for_testing.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if uname -a | grep Darwin >/dev/null 2>&1; then
$SUDO rm chrome-for-testing.zip
$SUDO mv ./chrome-mac-arm64 /opt/chrome-for-testing
# leveraging /opt instead of /Applications/Google Chrome for Testing.app/Contents/MacOS/Google Chrome for Testing as this should be temporary
$SUDO ln -fs /opt/chrome-for-testing/chrome /usr/local/bin/chrome
$SUDO ln -fs /opt/chrome-for-testing/chrome "$ORB_PARAM_DIR/chrome"
else
echo "Version $target_version doesn't exist"
#exit 1
Expand All @@ -36,6 +36,7 @@ if uname -a | grep Darwin >/dev/null 2>&1; then
if [ "$ORB_PARAM_INSTALL_CHROMEDRIVER" = true ] ; then
$SUDO curl -s -o chrome-for-testing-driver.zip "https://storage.googleapis.com/chrome-for-testing-public/$target_version/mac-arm64/chromedriver-mac-arm64.zip"
$SUDO unzip chrome-for-testing-driver.zip >/dev/null 2>&1
$SUDO rm chrome-for-testing-driver.zip
$SUDO mv chromedriver-mac-arm64/chromedriver chromedriver
fi
elif command -v apt >/dev/null 2>&1; then
Expand All @@ -51,7 +52,7 @@ elif command -v apt >/dev/null 2>&1; then
$SUDO unzip chrome-for-testing.zip >/dev/null 2>&1
$SUDO rm chrome-for-testing.zip
$SUDO mv ./chrome-linux64 /opt/chrome-for-testing
$SUDO ln -fs /opt/chrome-for-testing/chrome /usr/local/bin/chrome
$SUDO ln -fs /opt/chrome-for-testing/chrome "$ORB_PARAM_DIR/chrome"
else
echo "Version $target_version doesn't exist"
exit 1
Expand All @@ -66,6 +67,7 @@ elif command -v apt >/dev/null 2>&1; then
if [ "$ORB_PARAM_INSTALL_CHROMEDRIVER" = true ] ; then
$SUDO curl -s -o chrome-for-testing-driver.zip "https://storage.googleapis.com/chrome-for-testing-public/$target_version/linux64/chromedriver-linux64.zip"
$SUDO unzip chrome-for-testing-driver.zip >/dev/null 2>&1
$SUDO rm chrome-for-testing-driver.zip
$SUDO mv chromedriver-linux64/chromedriver chromedriver
fi
fi
Expand Down