Cursor keys in tables without modifiers #71 #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cursor keys in tables work only without modifiers, so we can map up/down with modifiers to other functions
micheldebree
added
bug
micheldebree
changed the title
Collaborator
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Cursor keys in tables work only without modifiers,
so we can map up/down with modifiers to other functions
Fixes #71
Open issues:
up/down (arrows without modifier) in the song order overview now also triggers instrument up/down (arrows with Cmd modifier). Weird because the modifier is not pressed.General issue:
There is a general issue with mapping keys for different keyboards; if the key I want to map happens to share the same key with another key, I have to use the modifier. For example the + key is above the = on my keyboard. So I have to map SDLK_EQUALS with modifier Shift. This doesn't work when the keyboard layout is different and the + key is somewhere else. This makes it almost impossible to map keys that share the same key.
Not sure if this is an SDL thing, or if it's the way we implemented key handling.