fix no max_tokens in payload when the vision model name does not cont…

[dustookk]

…ain 'vision'.

💻 变更类型 | Change Type

• feat
• fix
• refactor
• perf
• style
• test
• docs
• ci
• chore
• build

🔀 变更说明 | Description of Change

Fix no 'max_tokens' in the payload when the vision model name does not contain 'vision'

📝 补充信息 | Additional Information

&& modelConfig.model.includes("preview") 会导致常规 vision model 走不进 if 代码块，从而无法设置max_tokens

本地出现的bug是上传图片后，openai回复断流。 删除 && 后正常

Summary by CodeRabbit

• New Features

  • Simplified the logic for assigning the max_tokens parameter in the vision model requests, enhancing compatibility across various model configurations.

• Bug Fixes

  • Improved request handling for vision models, ensuring that max_tokens is applied more consistently.

[vercel]

@dustookk is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The recent modifications to the ChatGPTApi class in the OpenAI platform streamline the handling of the max_tokens parameter for vision models. By eliminating the condition that required the model to be in "preview" status, the code now ensures that max_tokens is applied whenever a valid visionModel is present. This change enhances the flexibility of request construction across different models.

Changes

File Path	Change Summary
app/client/platforms/openai.ts	Simplified logic for setting max_tokens in ChatGPTApi by removing the "preview" condition.

Poem

In a world where tokens flow,
The vision models start to glow.
No more checks for "preview" bright,
All models shine with new delight!
Hoppity hop, let changes ring,
A brighter code, oh what joy to bring! 🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Your build has completed!

Preview deployment

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ffe3269 and 56eb9d1.

Files selected for processing (1)

• app/client/platforms/openai.ts (1 hunks)

Additional comments not posted (1)

app/client/platforms/openai.ts (1)

193-194: LGTM! Simplified condition for max_tokens.

The removal of the additional condition ensures that max_tokens is set for all vision models, improving flexibility and aligning with the PR objectives.