Skip to content

chore: add should_override_forkchoice_update spec test check#8020

Merged
ensi321 merged 5 commits intonc/proposer-boost-reorg-fix-1from
nflaig/should_override_forkchoice_update_checks
Jun 27, 2025
Merged

chore: add should_override_forkchoice_update spec test check#8020
ensi321 merged 5 commits intonc/proposer-boost-reorg-fix-1from
nflaig/should_override_forkchoice_update_checks

Conversation

@nflaig
Copy link
Copy Markdown
Member

@nflaig nflaig commented Jun 27, 2025

Motivation

We are not running should_override_forkchoice_update spec tests from ethereum/consensus-specs#3034 as checks are missing.

Description

@nflaig nflaig marked this pull request as ready for review June 27, 2025 10:52
@nflaig nflaig requested a review from a team as a code owner June 27, 2025 10:53
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 55.66%. Comparing base (2f2eaf1) to head (bba4b04).
Report is 1 commits behind head on nc/proposer-boost-reorg-fix-1.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           nc/proposer-boost-reorg-fix-1    #8020      +/-   ##
=================================================================
- Coverage                          55.71%   55.66%   -0.06%     
=================================================================
  Files                                834      834              
  Lines                              59218    59542     +324     
  Branches                            4571     4594      +23     
=================================================================
+ Hits                               32995    33143     +148     
- Misses                             26156    26331     +175     
- Partials                              67       68       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nflaig nflaig changed the title chore: add should_override_forkchoice_update spec test check chore: add should_override_forkchoice_update spec test check Jun 27, 2025
@ensi321 ensi321 merged commit b45ea37 into nc/proposer-boost-reorg-fix-1 Jun 27, 2025
17 checks passed
@ensi321 ensi321 deleted the nflaig/should_override_forkchoice_update_checks branch June 27, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants