feat: swap @chainsafe/bls to use napi blst implementation#6362
Closed
matthewkeil wants to merge 8 commits intounstablefrom
Closed
feat: swap @chainsafe/bls to use napi blst implementation#6362matthewkeil wants to merge 8 commits intounstablefrom
matthewkeil wants to merge 8 commits intounstablefrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6362 +/- ##
============================================
- Coverage 61.72% 60.15% -1.57%
============================================
Files 555 407 -148
Lines 58204 46523 -11681
Branches 1839 1551 -288
============================================
- Hits 35925 27986 -7939
+ Misses 22240 18505 -3735
+ Partials 39 32 -7 |
Contributor
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
Contributor
Contributor
37d5b4d to
bdea610
Compare
Member
Author
Member
Author
Contributor
|
memory on service deployment is usually higher than that of docker ChainSafe/js-libp2p-gossipsub#468 (comment) just reviewed the memory in the last 2 days, rss has been stable and decreased over time
|
4c07c34 to
0a5c670
Compare
This was referenced Apr 11, 2024
Closed
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.























Motivation
DRAFT PR. Not ready for full review.
Branch is deployed to
feat2to collect metricsDescription
Updated
@chainsafe/blsto use the Napi version of@chainsafe/blst. Added async codepaths to bls processing an added flag to allow selection ofWorkerpool or libuv threadpool.