feat: regen to use different state caches based on nHistoricalStates flag#6359
Closed
feat: regen to use different state caches based on nHistoricalStates flag#6359
Conversation
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6359 +/- ##
============================================
- Coverage 60.15% 59.95% -0.20%
============================================
Files 407 399 -8
Lines 46511 43592 -2919
Branches 1550 1382 -168
============================================
- Hits 27980 26137 -1843
+ Misses 18499 17426 -1073
+ Partials 32 29 -3 |
Contributor
Author
|
e2e tests are stable, passed 6 times. The key thing is to use |
8c18c82 to
0b90609
Compare
Contributor
Author
|
decide to separate this PR to multiple PRs to make it easier to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nHistoricalStatesflag, by default leave itfalseDescription
chain.nHistoricalStatesflagchain.maxBlockStates(default to 32) for the new block state andchain.maxCPStateEpochsInMemory(default to 2) for the persistent cp stateTradeoff of this approach:
part of #5968