test: introduce beacon api test ignore list#6171
Merged
wemeetagain merged 27 commits intounstablefrom Dec 19, 2023
Merged
Conversation
jeluard
changed the title
jeluard
changed the title
jeluard
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6171 +/- ##
=============================================
+ Coverage 0 90.35% +90.35%
=============================================
Files 0 78 +78
Lines 0 8087 +8087
Branches 0 490 +490
=============================================
+ Hits 0 7307 +7307
- Misses 0 772 +772
- Partials 0 8 +8 |
jeluard
changed the title
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Dec 8, 2023
jeluard
force-pushed
the
jeluard/beacon-api-ignore-list
branch
from
7d7e4ca to
12c7ef4
Compare
nflaig
reviewed
Dec 12, 2023
nflaig
reviewed
Dec 13, 2023
nflaig
reviewed
Dec 14, 2023
nflaig
reviewed
Dec 14, 2023
Member
nflaig
left a comment
nflaig
left a comment
There was a problem hiding this comment.
Looks pretty good, I like the semantics. Just some minor nits
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
nflaig
previously approved these changes
Dec 14, 2023
nazarhussain
requested changes
Dec 18, 2023
Contributor
Author
|
@nazarhussain your points have been addressed |
nazarhussain
approved these changes
Dec 19, 2023
nflaig
approved these changes
Dec 19, 2023
twoeths
pushed a commit
that referenced
this pull request
Dec 22, 2023
* Fix operationId of light_client routes * Fix operationId of bls_to_execution_changes routes * Update beacon api spec version to 2.4.0 * Push case change * Remove now useless file * fix: lints * fix: filter broken test * Revert "Fix operationId of light_client routes" This reverts commit 91cd2af. * Revert "Fix operationId of bls_to_execution_changes routes" This reverts commit ad53c2d. * test: ignore missing routes * test: allow to filter required properties from testing * fix: incorrect case * test: fixed incorrect test filtering * fix: lints * fix: cleanup * test: allow more fine grain API tests filtering * fix: lints * test: increase JSON schema validation strictness * fix: restore removed keyword implementation * test: improve filtering semantic * test: add support for JSONPath syntax to filtering * fix: typo Co-authored-by: Nico Flaig <nflaig@protonmail.com> * fix: wording Co-authored-by: Nico Flaig <nflaig@protonmail.com> * test: improve semantic * test: added issue for context * fix: improved issues references * fix: incorrect dotted property parsing --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Member
|
🎉 This PR is included in v1.14.0 🎉 |
ensi321
pushed a commit
to ensi321/lodestar
that referenced
this pull request
Jan 22, 2024
* Fix operationId of light_client routes * Fix operationId of bls_to_execution_changes routes * Update beacon api spec version to 2.4.0 * Push case change * Remove now useless file * fix: lints * fix: filter broken test * Revert "Fix operationId of light_client routes" This reverts commit 91cd2af. * Revert "Fix operationId of bls_to_execution_changes routes" This reverts commit ad53c2d. * test: ignore missing routes * test: allow to filter required properties from testing * fix: incorrect case * test: fixed incorrect test filtering * fix: lints * fix: cleanup * test: allow more fine grain API tests filtering * fix: lints * test: increase JSON schema validation strictness * fix: restore removed keyword implementation * test: improve filtering semantic * test: add support for JSONPath syntax to filtering * fix: typo Co-authored-by: Nico Flaig <nflaig@protonmail.com> * fix: wording Co-authored-by: Nico Flaig <nflaig@protonmail.com> * test: improve semantic * test: added issue for context * fix: improved issues references * fix: incorrect dotted property parsing --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure lodestar supports latest Beacon APIs.
Description
To allow for easier testing against latest Beacon API, a black-list of not-yet supported features/examples is introduced.
Relates to #5710
Builds on top of unstable...nflaig/update-beacon-spec-version
Steps to test or reproduce
All unit tests in
packages/apishould pass.