feat: add consensus_block_value to produceBlockV3#6136
Merged
g11tech merged 19 commits intoChainSafe:unstablefrom Dec 8, 2023
Merged
feat: add consensus_block_value to produceBlockV3#6136g11tech merged 19 commits intoChainSafe:unstablefrom
consensus_block_value to produceBlockV3#6136g11tech merged 19 commits intoChainSafe:unstablefrom
Conversation
g11tech
reviewed
Dec 5, 2023
g11tech
reviewed
Dec 5, 2023
packages/beacon-node/src/chain/produceBlock/computeNewStateRoot.ts
Outdated
Show resolved
Hide resolved
g11tech
reviewed
Dec 6, 2023
g11tech
reviewed
Dec 6, 2023
g11tech
reviewed
Dec 6, 2023
g11tech
reviewed
Dec 6, 2023
g11tech
suggested changes
Dec 6, 2023
Contributor
g11tech
left a comment
g11tech
left a comment
There was a problem hiding this comment.
mostly looks good, few changes then should be g2g 👍
ensi321
commented
Dec 7, 2023
g11tech
reviewed
Dec 8, 2023
g11tech
reviewed
Dec 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6136 +/- ##
=========================================
Coverage 80.02% 80.02%
=========================================
Files 19 19
Lines 1717 1717
Branches 155 155
=========================================
Hits 1374 1374
Misses 341 341
Partials 2 2 |
Member
|
🎉 This PR is included in v1.13.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up PR for #5880 which adds
consensus_block_valuetoproduceBlockV3. Please refer to the spec PR for the rationale of adding the field.Introduce a
RewardCachetype that is attached toBeaconStateCache. It holds proposer’s reward for one state transition. Reward info is set/updated throughout thestate_transition()