feat: implement blob sidecars with inclusion proof instead of signtaures#6089
Merged
feat: implement blob sidecars with inclusion proof instead of signtaures#6089
Conversation
g11tech
force-pushed
the
blobs-inclproof
branch
from
fcc2aec to
a417362
Compare
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Contributor
|
g11tech
force-pushed
the
blobs-inclproof
branch
from
6a0d02c to
8174dbf
Compare
Contributor
Author
yes it did, i changed base to just reflect this diff |
g11tech
force-pushed
the
blobs-inclproof
branch
5 times, most recently
from
860784d to
17154a8
Compare
g11tech
force-pushed
the
optimistic-verify
branch
from
1c1f667 to
e8d10c1
Compare
g11tech
force-pushed
the
optimistic-verify
branch
2 times, most recently
from
0e793db to
f43984e
Compare
g11tech
force-pushed
the
blobs-inclproof
branch
from
d5a5a47 to
5799ef2
Compare
dapplion
reviewed
Dec 20, 2023
packages/beacon-node/src/chain/seenCache/seenGossipBlockInput.ts
Outdated
Show resolved
Hide resolved
dapplion
reviewed
Dec 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6089 +/- ##
============================================
+ Coverage 80.83% 80.95% +0.11%
============================================
Files 185 185
Lines 17986 17935 -51
Branches 1082 1078 -4
============================================
- Hits 14539 14519 -20
+ Misses 3421 3389 -32
- Partials 26 27 +1 |
g11tech
force-pushed
the
blobs-inclproof
branch
from
40c7561 to
310b871
Compare
modify the api fix validator handling fix val build refactor the beacon node impl for the new blobs architecture get the build working with no blobs fix the blob sidecars transmisssion relocate compute blob sidecars relocate verify merkle branch verify inclusion proof fix tests and types fix unit test update the spec test versions skip newly required merkle proof runner change the minimal/mainnet preset based constant strategy add other constants to tests apply feedback apply feedback relocate utils
g11tech
force-pushed
the
blobs-inclproof
branch
from
1d0e4a7 to
3ceb6bf
Compare
twoeths
reviewed
Dec 25, 2023
| } | ||
| } | ||
|
|
||
| function validateInclusionProof(config: ChainForkConfig, blobSidecar: deneb.BlobSidecar): boolean { |
twoeths
reviewed
Dec 25, 2023
| | {code: BlobSidecarErrorCode.PARENT_UNKNOWN; parentRoot: RootHex} | ||
| | {code: BlobSidecarErrorCode.NOT_LATER_THAN_PARENT; parentSlot: Slot; slot: Slot} | ||
| | {code: BlobSidecarErrorCode.PROPOSAL_SIGNATURE_INVALID} | ||
| | {code: BlobSidecarErrorCode.INCLUSION_PROOF_INVALID} |
Contributor
There was a problem hiding this comment.
need to include slot, blob index here
Contributor
Author
|
thanks @tuyennhv , yes let me address then in a followup |
Member
|
🎉 This PR is included in v1.14.0 🎉 |
ensi321
pushed a commit
to ensi321/lodestar
that referenced
this pull request
Jan 22, 2024
…res (ChainSafe#6089) modify the api fix validator handling fix val build refactor the beacon node impl for the new blobs architecture get the build working with no blobs fix the blob sidecars transmisssion relocate compute blob sidecars relocate verify merkle branch verify inclusion proof fix tests and types fix unit test update the spec test versions skip newly required merkle proof runner change the minimal/mainnet preset based constant strategy add other constants to tests apply feedback apply feedback relocate utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement