webrtc: Send RESET_STREAM on abrupt substream close#6
Open
timwu20 wants to merge 1 commit intotim/support-flagsfrom
Open
webrtc: Send RESET_STREAM on abrupt substream close#6timwu20 wants to merge 1 commit intotim/support-flagsfrom
timwu20 wants to merge 1 commit intotim/support-flagsfrom
Conversation
haikoschol
approved these changes
Jan 20, 2026
timwu20
force-pushed
the
tim/support-reset-stream
branch
from
77b7678 to
a517791
Compare
timwu20
force-pushed
the
tim/support-reset-stream
branch
from
a517791 to
9ecfe8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a
Substreamis dropped without callingshutdown()(graceful close), theSubstreamHandlenow sends aRESET_STREAMflag to notify the remote peer of the abrupt termination. This follows the libp2p WebRTC specification for non-graceful stream termination.Changes
reset_sentfield toSubstreamHandleto track whether RESET_STREAM has been sentpoll_next()to detect abrupt closes (whenSubstreamis dropped without reachingFinAckedstate) and send RESET_STREAM before signaling closureshutdown()completes and state reachesFinAcked) do not send RESET_STREAMBehavior
shutdown()called, FIN_ACK received)SubstreamHandlereturnsNonedirectlySubstreamdropped withoutshutdown())SubstreamHandlesends RESET_STREAM, then returnsNone