scale: encode/decode []string in struct#560
Merged
edwardmack merged 11 commits intodevelopmentfrom Jan 24, 2020
Merged
Conversation
edwardmack
requested review from
ansermino,
noot,
ryanchristo and
thomasmodeneis
ryanchristo
approved these changes
Jan 23, 2020
Contributor
ryanchristo
left a comment
ryanchristo
left a comment
There was a problem hiding this comment.
Nice work! This looks good to me.
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* create encoder for []string * save commit * added ability to decode []string * go fmt project * removed extra logging * cleanup error check * refactor flow * added DecodeStringArray function * go fmt code
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to SCALE encode and decode structs that contain arrays of strings.
Changes
Tests:
Issues:
closes #394