refactor(pkg/trie/triedb): node level caching#4239
Merged
timwu20 merged 21 commits intodevelopmentfrom Nov 4, 2024
Merged
Conversation
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
4 times, most recently
from
30419cd to
941f91d
Compare
timwu20
requested review from
EclesioMeloJunior,
dimartiro and
jimjbrettj
as code owners
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
from
bea5ad3 to
1689aac
Compare
timwu20
force-pushed
the
tim/refactor-triedb
branch
from
dddbecc to
1ffda9a
Compare
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
from
1689aac to
2b1bc71
Compare
haikoschol
approved these changes
Oct 16, 2024
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
from
be0dd1e to
3b7fb2f
Compare
EclesioMeloJunior
approved these changes
Oct 17, 2024
dimartiro
approved these changes
Oct 18, 2024
Contributor
dimartiro
left a comment
dimartiro
left a comment
There was a problem hiding this comment.
Looks good.
Just some comments, one specifically regarding the performance of the iterator but it's not a blocker for this PR, we can create an issue and optimize it later if possible
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
2 times, most recently
from
215328f to
233aefd
Compare
Co-authored-by: Haiko Schol <[email protected]>
timwu20
force-pushed
the
tim/refactor-triedb-caching
branch
from
233aefd to
ed69972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CachedNodeandCachedValuewhich is used in theTrieCacheinterface. These are analogous types tocodec.EncodedNodeandcodec.EncodedValue.CachedNodeAccessto the recorder and is recorded accordinglyTrieDBfunctions.TrieDB.GetHashandtriedb.GetWithfunctions that useTrieLookupwith supplied cache.Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
closes #4157