feat(sync): Add badBlocks support#3214
Closed
dimartiro wants to merge 2 commits intoeclesio/fix-bootstrap-syncfrom
Closed
feat(sync): Add badBlocks support#3214dimartiro wants to merge 2 commits intoeclesio/fix-bootstrap-syncfrom
dimartiro wants to merge 2 commits intoeclesio/fix-bootstrap-syncfrom
Conversation
EclesioMeloJunior
requested changes
Apr 17, 2023
dot/sync/chain_sync.go
Outdated
Comment on lines
+1024
to
+1030
| for _, badBlockHash := range cs.badBlocks { | ||
| if bd.Hash.String() == badBlockHash { | ||
| logger.Errorf("Rejecting known bad block Number: %d Hash: %s", bd.Number(), bd.Hash) | ||
| return errBadBlock | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| for _, badBlockHash := range cs.badBlocks { | |
| if bd.Hash.String() == badBlockHash { | |
| logger.Errorf("Rejecting known bad block Number: %d Hash: %s", bd.Number(), bd.Hash) | |
| return errBadBlock | |
| } | |
| } | |
| if slices.Contains(cs.badBlocks, bd.Hash.String) { | |
| logger.Errorf("Rejecting known bad block Number: %d Hash: %s", bd.Number(), bd.Hash) | |
| return errBadBlock | |
| } |
Contributor
Author
There was a problem hiding this comment.
Done! Thks for the suggestion
Contributor
Author
|
I'll close this PR cause I splitted it in two, this is one and the second one will be using Eclesio's branch with the new sync to use this validation there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Change sync process to reject bad blocks and disconnect from that peer
Tests
make testIssues
#3202
Primary Reviewer
@EclesioMeloJunior