chore(dot/digest): fix TestHandler_GrandpaForcedChange by initializing runtimes mapping#3142
Closed
EclesioMeloJunior wants to merge 3 commits intoqdm12/hashtoruntimefrom
Closed
Conversation
EclesioMeloJunior
requested review from
edwardmack,
jimjbrettj,
kishansagathiya,
noot,
qdm12 and
timwu20
as code owners
3 tasks
qdm12
approved these changes
Mar 7, 2023
Contributor
There was a problem hiding this comment.
Awesome 💯 !! Also feel free to push to my branches directly, I'll be careful not to force push on my branches for the time being.
And also feel free to squash and merge to my branch 😉 I'll work only mornings to be sure we don't duplicate work and let you know on Elements
Member
Author
|
I will close this PR since it does not make sense as I am doing a refactor around the in-memory runtimes, more details here: #3151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TestHandler_GrandpaForcedChangewas not initializing/storing any runtime in theblocktree.runtimesfield, so when the functiononFinalisationis called it panics since there is no entry for the given block hashTests
go test -timeout 10m -run ^TestHandler_GrandpaScheduledChange$ github.com/ChainSafe/gossamer/dot/digest --tags=integration -vIssues
N/A
Primary Reviewer
@qdm12