Skip to content

chore(proto): fixes and CI check#2992

Merged
qdm12 merged 7 commits intodevelopmentfrom
qdm12/proto
Dec 7, 2022
Merged

chore(proto): fixes and CI check#2992
qdm12 merged 7 commits intodevelopmentfrom
qdm12/proto

Conversation

@qdm12
Copy link
Copy Markdown
Contributor

@qdm12 qdm12 commented Dec 6, 2022 •
edited
Loading

Changes

  • make proto was not working, found whilst reviewing feat(dot/sync): Remove the EndBlockHash from BlockRequestMessage #2977
  • Use go generate to generate Go code from proto file
  • Add CI check to ensure Go code is generated using expected proto-gen-go and protoc versions
  • Re-generate using protoc v3.21.10 and proto-gen-go v1.28.1
  • Print out protoc requirement when running make proto

Tests

Issues

Primary Reviewer

@EclesioMeloJunior

@qdm12 qdm12 force-pushed the qdm12/proto branch 2 times, most recently from 10afac6 to 528315b Compare December 6, 2022 13:37
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2022 •
edited
Loading

Codecov Report

Merging #2992 (40b68ad) into development (5c93488) will decrease coverage by 0.27%.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff               @@
##           development    #2992      +/-   ##
===============================================
- Coverage        52.08%   51.81%   -0.28%     
===============================================
  Files              220      220              
  Lines            27716    27716              
===============================================
- Hits             14436    14360      -76     
- Misses           12043    12125      +82     
+ Partials          1237     1231       -6

@qdm12 qdm12 marked this pull request as ready for review December 6, 2022 14:07
@qdm12 qdm12 mentioned this pull request Dec 6, 2022
Merged
EclesioMeloJunior
EclesioMeloJunior approved these changes Dec 6, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@qdm12 qdm12 added the PR Easy label Dec 6, 2022
jimjbrettj
jimjbrettj approved these changes Dec 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@qdm12 qdm12 merged commit 87d58e6 into development Dec 7, 2022
@qdm12 qdm12 deleted the qdm12/proto branch December 7, 2022 10:53
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2023

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@noot noot Awaiting requested review from noot

@edwardmack edwardmack Awaiting requested review from edwardmack

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qdm12 @EclesioMeloJunior @jimjbrettj