p2p, add Block Announce Network Message#296
Merged
edwardmack merged 8 commits intodevelopmentfrom Sep 18, 2019
Merged
Conversation
golangcibot
reviewed
Sep 17, 2019
dutterbutter
approved these changes
Sep 17, 2019
noot
approved these changes
Sep 17, 2019
golangcibot
reviewed
Sep 18, 2019
golangcibot
reviewed
Sep 18, 2019
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
- Added BlockHeaderMessage type - Created Encode function for BlockHeaderMessage - Created Decode function for BlockHeaderMessage - Created String function for BlockHeaderMessage - Created TestEncodeBlockAnnounceMessage test - Created TestDecodeBlockAnnounceMessage test
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code to handle Encoding and Decoding Block Announce Network Message. Palkadot Runtime Environment Specification section E.1.4.
Changes
BlockHeaderMessagetypeEncodefunction forBlockHeaderMessageDecodefunction forBlockHeaderMessageStringfunction forBlockHeaderMessageTestEncodeBlockAnnounceMessagetestTestDecodeBlockAnnounceMessagetestTests:
Issues:
closes #256