feat(lib/grandpa): improve determinePrevote method#2745
Closed
EclesioMeloJunior wants to merge 17 commits intodevelopmentfrom
Closed
feat(lib/grandpa): improve determinePrevote method#2745EclesioMeloJunior wants to merge 17 commits intodevelopmentfrom
determinePrevote method#2745EclesioMeloJunior wants to merge 17 commits intodevelopmentfrom
Conversation
62334b7 to
d2d8f39
Compare
c401626 to
6131d78
Compare
6131d78 to
6a60277
Compare
qdm12
reviewed
Aug 16, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2745 +/- ##
===============================================
+ Coverage 63.12% 63.21% +0.09%
===============================================
Files 213 213
Lines 27034 26991 -43
===============================================
- Hits 17064 17063 -1
+ Misses 8420 8375 -45
- Partials 1550 1553 +3 |
qdm12
reviewed
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
latestFinalizedHeaderBeforeBestBlockByvoting rule as I did not find too much information about it (probably include in other PR) refsTests
Issues
Primary Reviewer
@timwu20