Skip to content

fix(core): handle latest extrinsic version and fix handleTxnPool logic#2562

Closed
jimjbrettj wants to merge 42 commits intodevelopmentfrom
jimmy/supportLatestExtrinsic
Closed

fix(core): handle latest extrinsic version and fix handleTxnPool logic#2562
jimjbrettj wants to merge 42 commits intodevelopmentfrom
jimmy/supportLatestExtrinsic

Conversation

@jimjbrettj
Copy link
Copy Markdown
Contributor

@jimjbrettj jimjbrettj commented May 17, 2022

Changes

  • Change how we construct extrinsics to support latest runtime version
  • Add gssmrLatestTxnQueue runtime to run integration tests with the latest runtime for maintaining the transaction pool (to be removed at a later date)
  • Upgrade the centrifuge library to v4
  • Build decoding logic to decode and handle data returned from validate transaction runtime call

Tests

go test -tags integration github.com/ChainSafe/gossamer
go test ./dot/core -tags integration 
go test ./dot/core
go test ./dot/rpc/modules

Issues

#2462

Primary Reviewer

@timwu20

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2562 (9d09dac) into development (75fcd75) will decrease coverage by 0.23%.
The diff coverage is 53.81%.

❗ Current head 9d09dac differs from pull request most recent head 956b97c. Consider uploading reports for the commit 956b97c to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #2562      +/-   ##
===============================================
- Coverage        62.92%   62.69%   -0.24%     
===============================================
  Files              212      216       +4     
  Lines            27019    27200     +181     
===============================================
+ Hits             17003    17052      +49     
- Misses            8470     8588     +118     
- Partials          1546     1560      +14     

@jimjbrettj jimjbrettj marked this pull request as ready for review July 12, 2022 17:19
@jimjbrettj jimjbrettj force-pushed the jimmy/supportLatestExtrinsic branch 2 times, most recently from f4813d5 to 5154718 Compare July 21, 2022 20:44
@jimjbrettj jimjbrettj closed this Jul 25, 2022
@jimjbrettj jimjbrettj reopened this Jul 25, 2022
@jimjbrettj jimjbrettj marked this pull request as draft July 25, 2022 15:46
@jimjbrettj jimjbrettj force-pushed the jimmy/supportLatestExtrinsic branch 2 times, most recently from ff5794c to 956b97c Compare August 18, 2022 20:07
@jimjbrettj
Copy link
Copy Markdown
Contributor Author

jimjbrettj commented Sep 27, 2022

Closed and replaced with #2809

@jimjbrettj jimjbrettj closed this Sep 27, 2022
@jimjbrettj jimjbrettj deleted the jimmy/supportLatestExtrinsic branch April 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants