chore(lib/grandpa): SignedMessage Hash to BlockHash#2491
Merged
qdm12 merged 1 commit intodevelopmentfrom Apr 26, 2022
Merged
Conversation
8 tasks
Codecov Report
@@ Coverage Diff @@
## development #2491 +/- ##
===============================================
+ Coverage 61.57% 61.58% +0.01%
===============================================
Files 215 215
Lines 28215 28215
===============================================
+ Hits 17372 17376 +4
+ Misses 9079 9076 -3
+ Partials 1764 1763 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
EclesioMeloJunior
approved these changes
Apr 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Just rename
SignedMessageHashfield toBlockHashto avoid any confusionTests
go test -tags integration github.com/ChainSafe/gossamer/lib/grandpaIssues
Created following a discussion from #2485
Primary Reviewer
@jimjbrettj