chore(internal): move packages to internal directory#2139
Closed
qdm12 wants to merge 4 commits intodevelopmentfrom
Closed
chore(internal): move packages to internal directory#2139qdm12 wants to merge 4 commits intodevelopmentfrom
qdm12 wants to merge 4 commits intodevelopmentfrom
Conversation
c6d31f4 to
830c474
Compare
Codecov Report
@@ Coverage Diff @@
## development #2139 +/- ##
===============================================
+ Coverage 61.49% 61.52% +0.03%
===============================================
Files 213 213
Lines 27429 27446 +17
===============================================
+ Hits 16867 16887 +20
+ Misses 8692 8689 -3
Partials 1870 1870
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
c7294e6 to
091b785
Compare
Contributor
Author
|
Defunct new-year PR, some key takeaways are in #2292 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
πββοΈ This PR is designed to be nice with other PRs, and keep history of file movements for easy rebase/merge on development once it gets merged.
π 95% of deltas are import strings updated to have the
internal/part. File movements are not part of them. There are a few extra changes in logic to find the chains directory in tests ininternal/lib/utils/utils.go*.outfiles to*.jsonto avoid gitignore conflictstest_datapathslib,dot,testsandchaintointernaldirectory/internalsuffix todot,lib,chainandtestsimport pathschaindirectory ininternal/lib/utils/utils.godevelopmentwithgit rebase development.Tests
Issues
Primary Reviewer