Conversation
…nd human-readable genesis to be passed to it (#1500)
* Beginning new docs * Theming set up * General layouts n links sorted * Cleaned up * Updated Commandline * Cleaned a bit * Minor cleaning * Removed todo * Config page * Connect to Polkadotjs * Fixed dev resources * New categories sorted * Updated permalink * Corrected contributor doc * Removed unused partials * Tidying * Removed offical nodes page * Amended with feed back * Resolved a majority of feedback * Ammeded workflows * Feedback * Added diagram * Recent feedback * Test package content * Removed comment * Debugging page * Block production expansion * Typos * Host spec link Co-authored-by: noot <36753753+noot@users.noreply.github.com>
* generate random name if --name flag not set * update tests with name flag to handle random names * update tests that reference name cfg
* implement telemetry connection server * add telemetry for import block * setup telemetry to use node name from Global config * init telemetry connections based on genesis.json values * fix error message formatting * add tests for telemetry * implement no-telemetry cli flag * fix typos * cleanup error check * create TelemetryEndpoint struct * created connection data struct to hold connection data * make TelemetryEndpoints a pointer reference * add tests for interfaceToTelemetryEndpoint * update test to fix random name
Co-authored-by: Arijit Das <arijit@chainsafe.io>
Codecov Report
@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 58.62% 59.04% +0.41%
==========================================
Files 151 155 +4
Lines 15057 15293 +236
==========================================
+ Hits 8827 9029 +202
- Misses 4690 4705 +15
- Partials 1540 1559 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
@arijitAD could you name this something like "release v0.4.0" or "0.3.3" (whatever the version will be, I guess "0.4.0" since we have new features)? |
edwardmack
previously approved these changes
Apr 9, 2021
* Update package.json. * Disable package publish to npm. * Add support to skip a release.
* Add cache for network message.
edwardmack
previously approved these changes
Apr 13, 2021
* Fix Deepsource error. * Fix lint issues.
| name: Release | ||
| on: | ||
| push: | ||
| branches: [main, development] |
Contributor
There was a problem hiding this comment.
This indicates that when we merge to either main or development the release workflow is triggered. Don't we just want this to be main ? @arijitAD
Contributor
Author
There was a problem hiding this comment.
The job will be triggered but it won't trigger a release. I will fix this after this release is done.
noot
changed the title
noot
approved these changes
Apr 13, 2021
dutterbutter
approved these changes
Apr 13, 2021
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues