dot/rpc: implement chain_subscribeFinalizedHeads RPC method#1140
Merged
noot merged 11 commits intodevelopmentfrom Oct 29, 2020
Merged
dot/rpc: implement chain_subscribeFinalizedHeads RPC method#1140noot merged 11 commits intodevelopmentfrom
noot merged 11 commits intodevelopmentfrom
Conversation
noot
approved these changes
Oct 20, 2020
Contributor
noot
left a comment
noot
left a comment
There was a problem hiding this comment.
looks good, please add a test!
Contributor
Author
|
I've added testing for websockets. |
noot
reviewed
Oct 28, 2020
tests/utils/gossamer_utils.go
Outdated
| "--basepath", node.basePath, | ||
| "--rpchost", HOSTNAME, | ||
| "--rpcport", node.RPCPort, | ||
| "--rpcmods", "system,author,chain,state", |
noot
reviewed
Oct 28, 2020
tests/rpc/rpc_03-chain_test.go
Outdated
| map[string](interface{}){ | ||
| "subscription": float64(1), | ||
| "result": map[string](interface{}){ | ||
| "number": "0x04", |
Contributor
There was a problem hiding this comment.
is there a reason the expected block is block 4?
Contributor
Author
There was a problem hiding this comment.
No, 1 makes more sense, I've updated this.
noot
approved these changes
Oct 28, 2020
This was referenced Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Checklist
Issues