Merged
Conversation
Contributor
|
I'm having trouble with updating the lockfile because of work being done in this PR. See: |
cryptoquick
suggested changes
Feb 22, 2021
Contributor
cryptoquick
left a comment
cryptoquick
left a comment
There was a problem hiding this comment.
This is a lot of good work! Only one small nitpick, feel free to ignore if you like. I like how you were able to minimize a few clones, too.
cryptoquick
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Just going to keep as draft until I have more time to sink into debugging the issues
Reference issue to close (if applicable)
Closes
Other information and links