fix: resolve conflicts for upstream sync PR #24 #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π§ Automated Conflict Resolution
This PR resolves merge conflicts in #24 (main β carto/main upstream sync).
π― Resolution Strategy
Followed strict priority order:
π Files Modified
CARTO versions kept (infrastructure):
docker/Dockerfile.non_root- Preserved CARTO Prisma setup, litellm-proxy-extras wheel installation, and cache directory permissionslitellm/responses/litellm_completion_transformation/*.py- Preserved CARTO Redis session storage patches (marked with# PATCH:comments)Upstream versions accepted (core improvements):
enterprise/litellm_enterprise/integrations/prometheus.py- Accepted memory leak fix (removed jitter parameter)litellm/constants.py- Accepted APScheduler configuration constantslitellm/proxy/proxy_server.py- Accepted constant usage instead of hardcoded valueslitellm/llms/vertex_ai/gemini/transformation.py- Accepted null checks and type improvementsrequirements.txt- Accepted upstream dependency versions (litellm-proxy-extras==0.2.29)tests/**- Accepted upstream new test casesManually merged (combined both):
litellm-proxy-extras/litellm_proxy_extras/migrations/*.sql- Resolved whitespace conflicts (trivial)litellm/responses/litellm_completion_transformation/streaming_iterator.py- Kept CARTO Redis patches + added upstream annotation event handlinglitellm/responses/litellm_completion_transformation/transformation.py- Kept CARTO Redis methods + added upstream cost field preservationβ Testing Results
<<<<<<<,=======,>>>>>>>)make lint- Skipped (poetry not available in resolution environment)make lint-mypy- Skipped (poetry not available in resolution environment)make test-unit- Skipped (poetry not available in resolution environment)π Review Guidelines
Please verify:
# CARTO:sections)# PATCH:comments)π Key Resolution Decisions
docker/Dockerfile.non_root: Kept CARTO's comprehensive Prisma setup with PATH configuration, tmp directories, and cache permissions. This is essential for CARTO's OpenShift deployment.
prometheus.py: Accepted upstream's removal of
jitterparameter which was causing memory leaks. This is a critical bug fix that overrides CARTO's previous configuration.responses transformation files: Carefully preserved CARTO's Redis session storage functionality while accepting upstream's cost tracking and annotation event handling improvements.
requirements.txt: Accepted upstream version of litellm-proxy-extras (0.2.29) which includes all necessary CARTO migrations.
π What Happens After Merge
When this PR is merged into
carto/main:mainwill be incarto/main(with conflicts resolved)Branch flow:
π€ Automation Details
π Action Required: Review CARTO customizations and run CI/CD tests before merging.
Resolves conflicts in #24