Skip to content

[BREAKING] Change launchTask to Task.launch#76

Merged
mdiep merged 1 commit intomasterfrom
task-launch
Sep 24, 2016
Merged

[BREAKING] Change launchTask to Task.launch#76
mdiep merged 1 commit intomasterfrom
task-launch

Conversation

@ikesyo
Copy link
Member

@ikesyo ikesyo commented Sep 24, 2016

Another option is launch(task: Task, standardInput: SignalProducer<Data, NoError>? = nil) related to Swift 3 API Design Guidelines.

Diff ignoring whitespace: https://github.com/Carthage/ReactiveTask/pull/76/files?w=1

Copy link
Member

@mdiep mdiep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense. 👍🏻

@mdiep mdiep merged commit 42d3218 into master Sep 24, 2016
@mdiep mdiep deleted the task-launch branch September 24, 2016 19:48
@ikesyo
Copy link
Member Author

ikesyo commented Sep 25, 2016

Thanks! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants